Skip to content

Configure Controller Names #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jmrtnz94
Copy link

@jmrtnz94 jmrtnz94 commented May 2, 2023

Ref: #80

@jmrtnz94
Copy link
Author

jmrtnz94 commented May 2, 2023

Let me know what you think of the OperationGenerationMode name and its values.

@jmrtnz94
Copy link
Author

jmrtnz94 commented May 2, 2023

I'll update the unit tests after I get feedback on the implementation.

@alexcampana
Copy link
Owner

Seems like a reasonable approach to me! Once the unit tests are fixed I'll get it merged in.

@jmrtnz94
Copy link
Author

Updated unit tests!

@jmrtnz94
Copy link
Author

I'm not sure I like the following values for OperationGenerationMode but lmk what you think.

  • MultipleClientsFromPathSegmentAndOperationId
  • MultipleClientsFromFirstTagAndOperationId

@alexcampana
Copy link
Owner

Sorry for the delay, wanted to spend some more time thinking about this and then life got in the way.

It seems like nswag repurposed that setting from their client generator, so I'm in favor of changing the naming to be more controller specific. I'm thinking maybe ControllerNamingScheme with the options being PathSegment, FirstTag and then maybe in the future SingleController. Definitely open to other options though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants