Skip to content

[MWPW-175533] Hero Marquee lockup text overlap fix #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

overmyheadandbody
Copy link
Contributor

@overmyheadandbody overmyheadandbody commented Jul 9, 2025

This fixes an edge case in the Hero Marquee when a return is added between the lockup image and its text inside a con-block-row. The lockup pattern is used in the Editorial Card, Hero Marquee, Aside and Notification Ribbon & Pill. Based on the lockup pattern used in those blocks, I tried to make the 3 possible use-cases look uniform when used inside the Hero Marquee:

  • return between image(s) and text in a con-block-row;
  • space between image(s) and text in a con-block-row;
  • lockup as part of the main Hero Marquee content.
Before After
Screenshot 2025-07-09 at 17 35 18 Screenshot 2025-07-09 at 17 35 33

Resolves: MWPW-175533

Test URLs:

@overmyheadandbody overmyheadandbody requested a review from a team as a code owner July 9, 2025 15:39
Copy link
Contributor

aem-code-sync bot commented Jul 9, 2025

@hit11757 hit11757 self-assigned this Jul 10, 2025
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link
Contributor

@hit11757 hit11757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants