Skip to content

MWPW-175654: preload ucv3 script (#4477) #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

MWPW-175654: preload ucv3 script (#4477) #4478

merged 1 commit into from
Jun 26, 2025

Conversation

chrischrischris
Copy link
Contributor

@chrischrischris chrischrischris commented Jun 26, 2025

This is being merged directly to main due a cso
Approved by Thomislav Reil and Drew Cottrell

ucv3 script doesn't support modern preload
and requires an id attribute on the script element therefore we need to use loadScript instead of loadLink

Test on VPN with the stage urls.

Resolves: MWPW-175654

cc catalog test page: main--cc--adobecom.aem.live/products/catalog?martech=off&milolibs=mwpw-175654--milo--adobecom

Test URLs:

* MWPW-175654: preload ucv3 script

ucv3 script doesn't support modern preload
and requires an id attribute on the script element
therefore we need to use loadScript instead of loadLink

* add defer

* use window.milo.deferredPromise
@chrischrischris chrischrischris requested a review from a team as a code owner June 26, 2025 21:44
Copy link
Contributor

aem-code-sync bot commented Jun 26, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

SNOW Change Request Transaction ID: 0000019746cb9d8a-2be0a8a

@chrischrischris chrischrischris merged commit ddf2092 into main Jun 26, 2025
15 of 18 checks passed
@chrischrischris chrischrischris deleted the ucv3preload branch June 26, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants