Skip to content

[Release] Stage to Main #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 24, 2025
Merged

[Release] Stage to Main #4447

merged 11 commits into from
Jun 24, 2025

Conversation

overmyheadandbody and others added 4 commits June 23, 2025 09:21
* Having tooltip works as milo tooltip does.

* hidetooltip test.

* hide -> show

* mas build

* tooltip remove events

* Tooltip test

* Adding event.preventDefault();

* remove white line on pointer.

* add -> toggle.

* toggle test.

* show -> hide

* no message

* trying to push the code.

* Fixing the small bug that the first touch doesn't work on chrome.

* Migrate the icon code into merch-card.js and icon size update.

* moving it back to plans.css.js

* Adding condition for the padding.

* Test for iphone.

* hover > mouseover event
…y in MEP to more easily add that data to a link (#4268)

* [MWPW-174157]: added alloy event handling for MEP and  Manifest

* added href_# instead of #

* refactored event payload

* refactored event payload

* refactored utils to use a more modular approach

* changed documentUnloading to false

* optimized code

---------

Co-authored-by: Denys Fedotov <[email protected]>
Co-authored-by: Vivian A Goodrich <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jun 23, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot

@milo-pr-merge milo-pr-merge bot requested review from a team and vgoodric as code owners June 23, 2025 09:21
Copy link
Contributor

aem-code-sync bot commented Jun 23, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jun 23, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

SNOW Change Request Transaction ID: 0000019746cb97b2-23f7642

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@3ch023 3ch023 temporarily deployed to milo_pr_merge June 23, 2025 11:34 — with GitHub Actions Inactive
* wip

* v1

* adding href check for ctas

* lint

---------

Co-authored-by: Predrag Markovic <[email protected]>
* MWPW-173962: refactor&simplify

* add full nala coverage for fallback

* add nala tests for catalog deeplink

* add checkout unit test

* fix lint issues

* fix unit test
)

center on mobile for center variant of notification
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/3ec9176d347a7920d93260c81badb1926ad71a7d/libs/features/mas/test/checkout-button.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/3ec9176d347a7920d93260c81badb1926ad71a7d/libs/features/mas/test/checkout-link.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/3ec9176d347a7920d93260c81badb1926ad71a7d/libs/features/mas/test/checkout.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/3ec9176d347a7920d93260c81badb1926ad71a7d/libs/features/mas/test/hydrate.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/3ec9176d347a7920d93260c81badb1926ad71a7d/libs/features/mas/test/mas-commerce-service.test.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@mokimo mokimo temporarily deployed to milo_pr_merge June 23, 2025 12:36 — with GitHub Actions Inactive
…4444)

* Update CODEOWNERS to assign ownership for personalization and add martech attributes

* Remove ownership assignment for the 'mep' feature from CODEOWNERS
* MWPW-171321 prefilling wcs cache

- if mas/io response contains wcs,
- if wcs object contains artifacts corresponding with current env,
- prefilling wcs cache with those entries

* add mas.disableWcsCache parameter
- add unit tests

* exiting in case no conf is here

* MWPW-171321 fixing plan type display

* update Nala with ABM check

---------

Co-authored-by: cod23684 <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@mokimo mokimo temporarily deployed to milo_pr_merge June 23, 2025 16:21 — with GitHub Actions Inactive
…nt (#4417)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <[email protected]>

* [Release] Stage to Main (#3817)

* ENB-7820: Add values for event95 (#3782)

* Add values for event95

* Fix failing test case

* Remove spaces

* Minimal Impact: Add extra key for  other features

* Minimal Impact: change function name

* [MWPW-168691] - Aside cta shrink JP (#3785)

* [MWPW-168691] cta shrink fix

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] updated solution

* Revert "[MWPW-168691]"

This reverts commit a70f9ca.

Revert "[MWPW-168691] update"

This reverts commit 6aac2bc.

Revert "[MWPW-168691] update"

This reverts commit c0c6a34.

Revert "[MWPW-168691] update"

This reverts commit 017edf0.

Revert "[MWPW-168691] update"

This reverts commit 219e5fd.

Revert "[MWPW-168691] update"

This reverts commit a7df2b5.

Revert "[MWPW-168691] update"

This reverts commit 299a7d7.

Revert "[MWPW-168691] update"

This reverts commit 6709515.

Revert "[MWPW-168691] cta shrink fix"

This reverts commit c90eea6.

* MWPW-168691: Prevent cta jp word wrap on large screens

* MWPW-168691: Fix notification jp cta

* MWPW-168691: Hide wbr cta for tablet and desktop

---------

Co-authored-by: Ratko Zagorac <[email protected]>

* MWPW-169371 : Adding countryCode config to UNav (#3793)

* Adding countryCode config to UNav

* Updating countryCode for uk

* Updating for upperCase

* Passing countryCode according to MAS mapping for UCv3 cart

---------

Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>

* MWPW-167716 Remove await from both gnav and georouting (#3680)

Made georouting and globalnavigation non blocking

* Lnav title and headline text overflow support (#3781)

* Lnav title text overflow support

* Fix for chevron icon top position

* Adding white space break for localnav menus

* Adding white space break for localnav menus

* Adding white space break for localnav list menus

* Inclufing white spaces to non menu items

* [MWPW-169500] SEO- Links check failing breaks Preflight (#3803)

fixed preflight seo links check

* MWPW-169732 Fetch resources from adobe.com/federal instead of https://main--federal--adobecom.aem.live/federal (#3813)

* on prod federal content for the standalone gnav and footer needs to come from

* handled situations where we're stage and when we're neither stage nor prod

* MWPW-169416 [MEP] stop treating remove action differently in preview (#3789)

* truly remove elements, even in preview

* unit test update

* fix for MWPW-169416, new remove action in MEP

* lint clean-up

---------

Co-authored-by: John Pratt <[email protected]>

---------

Co-authored-by: Swati Mukherjee <[email protected]>
Co-authored-by: Dušan Kosanović <[email protected]>
Co-authored-by: Ratko Zagorac <[email protected]>
Co-authored-by: sonawanesnehal3 <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Raghav Sharma <[email protected]>
Co-authored-by: Bandana Laishram <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Vivian A Goodrich <[email protected]>
Co-authored-by: John Pratt <[email protected]>

* Revert "Improve carousel accessibility (#4103)" from prod (#4195)

Revert "Improve carousel accessibility (#4103)"

This reverts commit 34d2016.

* Revert "[MWPW-173470] - Korea free trial restrict" (main) (#4236)

Revert "[MWPW-173470] - Korea free trial restrict (#4185)"

This reverts commit 351cfe6.

* MWPW-173888 + MWPW-173919: Appending extra options for relative urls & multiple cta reopen fix (#4237)

* Korea free trial restrict (#4282)

* [MWPW-173016] - block korea free trial links/buttons

* [MWPW-173016] - korea text filter added

* [MWPW-173016] - update if

* [MWPW-173016] - code optimization

* [MWPW-173016] - improve import

* [MWPW-173016] - modal check, string check added

* [MWPW-173016] - strings added

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - update logic

* [MWPW-173470] - remove whitespace

* [MWPW-173470] - optimize

* [MWPW-173470] - remove variable

* [MWPW-173016] - optimize code

* [MWPW-173016] - group logic

* [MWPW-173016] - merch solution added

* [MWPW-173016] - merch ref comment added

* [MWPW-173470] - null safe

* [MWPW-173470] - code optimization

* [MWPW-173470] - nav korea restrict coverage

* [MWPW-173470] - fix eslint console error

---------

Co-authored-by: Dusan Kosanovic <[email protected]>

* Revert "[MWPW-173717] Hyphenate large headings on mobile (#4199)"

This reverts commit 7b82821.

* MWPW-74582: ensure that empty primaryCtas are not being sent through to caas

* ugh rebasing stage is the worst

* omg literally the worst

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* rebase weirdness

* omg this whitespace will be the death of me

* MWPW-74582: carlos revsion

---------

Co-authored-by: Okan Sahin <[email protected]>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Raghav Sharma <[email protected]>
Co-authored-by: Swati Mukherjee <[email protected]>
Co-authored-by: Dušan Kosanović <[email protected]>
Co-authored-by: Ratko Zagorac <[email protected]>
Co-authored-by: sonawanesnehal3 <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Bandana Laishram <[email protected]>
Co-authored-by: Robert Bogos <[email protected]>
Co-authored-by: Vivian A Goodrich <[email protected]>
Co-authored-by: John Pratt <[email protected]>
Co-authored-by: Angelo Statescu <[email protected]>
Co-authored-by: Rares Munteanu <[email protected]>
Co-authored-by: Narcis Radu <[email protected]>
Co-authored-by: Sheridan Sunier <[email protected]>
@mokimo mokimo temporarily deployed to milo_pr_merge June 24, 2025 08:23 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 24, 2025 09:19 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 24, 2025 10:09 — with GitHub Actions Inactive
@milo-pr-merge milo-pr-merge bot merged commit 418630e into main Jun 24, 2025
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.