MWPW-174297: CCD mini card variant #4336
Conversation
|
|
||
| await test.step('2. Verify CCD Mini Card content', async () => { | ||
| const cardLocator = miniCard.getCard(data.fragment); | ||
| await expect(cardLocator).toBeVisible(); |
There was a problem hiding this comment.
@yesil will try adding here await for card locator. Might be that the cards are not loading fast enough.
| test.beforeEach(async ({ page, browserName }) => { | ||
| miniCard = new MiniCard(page); | ||
| if (browserName === 'chromium') { | ||
| await page.setExtraHTTPHeaders({ 'sec-ch-ua': '"Chromium";v="123", "Not:A-Brand";v="8"' }); |
There was a problem hiding this comment.
@yesil I have added this http headers here. It is needed for automation in chromium for commerce. Without it, the requests get rejected by the bot.
| @@ -10,7 +10,7 @@ import { MODAL_TYPE_3_IN_1 } from './constants.js'; | |||
| /** | |||
| * generate Checkout configuration | |||
| */ | |||
| export function Checkout({ settings }) { | |||
| export function Checkout({ settings, providers }) { | |||
There was a problem hiding this comment.
hehe i see, providers are back :)
There was a problem hiding this comment.
actually, they were in the code since the very early Milo commerce but we never used them, now we will need them with settings coming at card level.
| } = settings; | ||
|
|
||
| let options = { |
There was a problem hiding this comment.
are you sure we need this? i vaguely remember removing it because it wasn't used
There was a problem hiding this comment.
yes, the providers are ran against the default options.
technically there can be more than 1 provider, although we should strive to be reasonable and keep it as close as to 0 or 1.
when a provider gets the options, it doesn't know whether another provider has already modified the options.
so we need an initial options object.
CCD mini variant card.
mas-ff-defaults is enabled by default in MAS, but disabled explicitly in merch.js for Milo.
aem-fragment: moved caching from element scope to module scope
support price-literals override via aem-fragment response.
Resolves:
MWPW-174297
MWPW-174581
https://jira.corp.adobe.com/browse/MWPW-175099
screenshot:
docs: mwpw-174297--milo--adobecom.aem.live/libs/features/mas/docs/merch-card.html#properties
Test URLs: