Skip to content

Asset Library: Checking for renditionLinks before searching to prevent TypeError #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

kharris-reingold
Copy link
Contributor

Description

Fixing issue with the Asset Library not working for assets without rendition links (like zip files)

Related Issue

#481

Motivation and Context

Since EDS does not support most file types, need the ability to easily link to files like this from the asset selector pulling from AEM Assets

How Has This Been Tested?

Adjusted da-assets.js in browser to confirm fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@auniverseaway auniverseaway merged commit 5f68466 into adobe:main Jul 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants