Add selection options for DynamicMedia SmartCrops #480
+373
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2025 11:03
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sagarsane
reviewed
Jul 8, 2025
blocks/edit/da-assets/da-assets.js
Outdated
| if (dmDeliveryEnabled && activationTarget !== 'delivery' && reviewStatus !== 'approved') { | ||
| assetSelectorWrapper.style.display = 'none'; | ||
| cropSelectorWrapper.style.display = 'block'; | ||
| cropSelectorWrapper.innerHTML = '<p class="da-dialog-asset-error">The selected Asset is not available. Please check the activation target and review status.</p><div class="da-dialog-asset-buttons"><button class="back">Back</button><button class="cancel">Cancel</button></div>'; |
There was a problem hiding this comment.
Would this be a better message?
The selected asset is not Approved for Delivery. Please choose another asset.
Since regular authors may not know what activation target or review status means.
|
Tested both the features and both look great! Thank you for this! |
sagarsane
approved these changes
Jul 10, 2025
auniverseaway
previously approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives more flexibility in using the AssetSelector for adding images to DA.
aem.asset.dm.delivery = 'on'This option adds DynamicMedia URLs (https://delivery-...) to the DA documents but still use the author (with folder structure) to select via the AssetSelector UI.
aem.asset.smartcrop.select = 'on'This options enables a selection screen after the AssetSelector UI closes to give the authors a options to choose which DynamicMedia SmartCrop rendition should be added to the document.
responsive-imagesheet in configOn this sheet administrators can define a set of crops which should be added together as a set to the document. It is also aware of the current selection (see
position) and can provide different sets for inside or outside blocks. If the configuration applies the author has in the crop selection view not only the option to add a single image but choose from predefined sets like adding variant 1-1 and 3-4 together.Configuration
| name | position | crops |
| <arbitrary descriptive name> | <everywhere|outside-block|<block name>> | <list of smartcrop ids> |
| default | everywhere | 1:1, 3:4 |
| Hero | hero | 16:9, 4:3, 3:4 |
Additional Features
dam:activationTargetandreviewStatusmetadata properties are checked before trying to add an image and give the user a reasonable error messageMotivation and Context
In our client project the authors want to have a flexible way to not only choose from DynamicMedia SmartCrops and add them to the document but also see those images directly in the document and having the option to exchange individual crop variants with completely different assets if necessary.
How Has This Been Tested?
I developed the JS by using the browsers dev tools override mechanism, injecting my adjusted da-assets.js and da-assets.css. I could not use a normal local setup as testing requires AEM Asset access which is not possible with the staging IMS for my user.
Screenshots:
Custom Image Profile Setup in AEMaaCS:
Manually Adjusting SmartCops per Asset if necessary
Sample Config in DA
Crop Selection Screen after selecting an Asset via AssetSelector
Types of changes
Checklist:
I was not able to run the test locally and there does not seem to be an existing test for that part of da-live. Please advice how to proceed.