Skip to content

fix: panic on none unwrap #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025

Conversation

dshemin
Copy link
Contributor

@dshemin dshemin commented Aug 13, 2025

Fix issue #198


Important

Fixes panic in menu.rs by checking for None before unwrapping table_map.get_index(self.schema_index) in handle_key_events.

This description was created by Ellipsis for 295a280. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 295a280 in 1 minute and 27 seconds. Click for details.
  • Reviewed 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_Ae10RjqbRloNV7tq

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@achristmascarl
Copy link
Owner

thanks for catching and fixing @dshemin; I just made some minor changes to satisfy clippy

@achristmascarl achristmascarl merged commit bb1c76d into achristmascarl:main Aug 14, 2025
10 checks passed
Copy link

Included in release v0.3.5

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 14, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [achristmascarl/rainfrog](https://github.com/achristmascarl/rainfrog) | patch | `v0.3.4` -> `v0.3.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>achristmascarl/rainfrog (achristmascarl/rainfrog)</summary>

### [`v0.3.5`](https://github.com/achristmascarl/rainfrog/releases/tag/v0.3.5)

[Compare Source](achristmascarl/rainfrog@v0.3.4...v0.3.5)

<!-- Release notes generated using configuration in .github/release.yml at v0.3.5 -->

#### What's Changed

- fix clippy, collapse ifs by [@&#8203;achristmascarl](https://github.com/achristmascarl) in achristmascarl/rainfrog#196
- Bump slab from 0.4.10 to 0.4.11 in the cargo group across 1 directory by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in achristmascarl/rainfrog#197
- fix: panic on none unwrap by [@&#8203;dshemin](https://github.com/dshemin) in achristmascarl/rainfrog#199

#### New Contributors

- [@&#8203;dshemin](https://github.com/dshemin) made their first contribution in achristmascarl/rainfrog#199

**Full Changelog**: achristmascarl/rainfrog@v0.3.4...v0.3.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42Ni4yIiwidXBkYXRlZEluVmVyIjoiNDEuNjYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants