-
-
Notifications
You must be signed in to change notification settings - Fork 72
fix: panic on none unwrap #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 295a280 in 1 minute and 27 seconds. Click for details.
- Reviewed
19
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_Ae10RjqbRloNV7tq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
295a280
to
82ac69d
Compare
thanks for catching and fixing @dshemin; I just made some minor changes to satisfy clippy |
Included in release v0.3.5 |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [achristmascarl/rainfrog](https://github.com/achristmascarl/rainfrog) | patch | `v0.3.4` -> `v0.3.5` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>achristmascarl/rainfrog (achristmascarl/rainfrog)</summary> ### [`v0.3.5`](https://github.com/achristmascarl/rainfrog/releases/tag/v0.3.5) [Compare Source](achristmascarl/rainfrog@v0.3.4...v0.3.5) <!-- Release notes generated using configuration in .github/release.yml at v0.3.5 --> #### What's Changed - fix clippy, collapse ifs by [@​achristmascarl](https://github.com/achristmascarl) in achristmascarl/rainfrog#196 - Bump slab from 0.4.10 to 0.4.11 in the cargo group across 1 directory by [@​dependabot](https://github.com/dependabot)\[bot] in achristmascarl/rainfrog#197 - fix: panic on none unwrap by [@​dshemin](https://github.com/dshemin) in achristmascarl/rainfrog#199 #### New Contributors - [@​dshemin](https://github.com/dshemin) made their first contribution in achristmascarl/rainfrog#199 **Full Changelog**: achristmascarl/rainfrog@v0.3.4...v0.3.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42Ni4yIiwidXBkYXRlZEluVmVyIjoiNDEuNjYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Fix issue #198
Important
Fixes panic in
menu.rs
by checking forNone
before unwrappingtable_map.get_index(self.schema_index)
inhandle_key_events
.handle_key_events
inmenu.rs
by checking forNone
before unwrappingtable_map.get_index(self.schema_index)
.Ok(None)
ifschema_index
does not exist intable_map
.Option::unwrap()
on aNone
value on key press 'Control + 1' #198.This description was created by
for 295a280. You can customize this summary. It will automatically update as commits are pushed.