fix clippy, collapse ifs

[achristmascarl]

Important

Refactor code by collapsing nested if statements using let-else construct across multiple files to improve readability and maintainability.

• Refactoring:
  • Collapse nested if statements using let-else construct in app.rs, editor.rs, favorites.rs, tui.rs, and utils.rs.
  • Improves code readability and maintainability without changing functionality.
• Specific Changes:
  • In app.rs, refactor mouse event handling logic in draw_layout().
  • In editor.rs, refactor transition_vim_state() to use let-else for command transmission.
  • In favorites.rs, refactor search handling logic in handle_key_events().
  • In tui.rs, refactor tick_rate(), frame_rate(), and mouse() methods.
  • In utils.rs, refactor panic handler initialization in initialize_panic_handler().

^{This description was created by for 16c7cff. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 16c7cff in 4 minutes and 6 seconds. Click for details.

• Reviewed 182 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. src/app.rs:524

• Draft comment:
  Good refactoring: nested mouse event ifs collapsed using let-chain for clarity.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. src/components/editor.rs:59

• Draft comment:
  Nicely collapsed nested ifs in transition_vim_state with let-chain.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. src/components/favorites.rs:207

• Draft comment:
  Simplified search-empty check using if-let chain for conciseness.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. src/tui.rs:71

• Draft comment:
  Improved tick_rate, frame_rate, and mouse setter readability using if-let.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

5. src/utils.rs:43

• Draft comment:
  Refactored panic handler exit logic using if-let chain for brevity.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

6. src/app.rs:559

• Draft comment:
  Typographical issue: It appears that "last_focused_tab" is intended to be invoked as a function (as seen on line 539). Consider changing self.state.focus = self.last_focused_tab; to self.state.focus = self.last_focused_tab(); to maintain consistency.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_wYjkFkF87FUgbHkk

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Included in release v0.3.5