bypass sqlparser

[achristmascarl]

closes #143

• add option to bypass query parser
• refactor for bypassing

---

Important

Add option to bypass SQL parser with new action and popup confirmation, updating query handling across database drivers.

• Behavior:
  • Add SubmitEditorQueryBypassParser action in action.rs to bypass SQL parser.
  • Modify start_query() in mysql.rs, postgresql.rs, and sqlite.rs to handle bypass_parser flag.
  • Add ConfirmBypass popup in confirm_bypass.rs to confirm bypass action.
• Refactoring:
  • Update Query action in action.rs to include bypass_parser boolean.
  • Modify get_execution_type() in mod.rs to return Option<Statement>.
  • Change statement_type to Option<Statement> in QueryResultsWithMetadata in mod.rs.
• Keybindings:
  • Add <F7> keybinding in .config/rainfrog_config.toml for SubmitEditorQueryBypassParser.

^{This description was created by for 6baab08. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 6baab08 in 2 minutes and 59 seconds. Click for details.

• Reviewed 523 lines of code in 13 files
• Skipped 0 files when reviewing.
• Skipped posting 10 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .config/rainfrog_config.toml:23

• Draft comment:
  Added new F7 keybinding for bypass query submission. Looks good.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. src/action.rs:29

• Draft comment:
  New action variant 'SubmitEditorQueryBypassParser' and updated Query variant now carrying a bypass_parser flag. The design is clear.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. src/app.rs:387

• Draft comment:
  In the Action::Query branch, bypass logic is implemented with a condition if *bypass && !confirmed. Ensure that the dereferencing is intentional; consider destructuring by value for clarity.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This appears to be a purely stylistic suggestion. The current code is perfectly functional and clear. Whether to use dereferencing or destructuring is a matter of personal/team preference. The comment doesn't identify any actual problems or risks. I could be undervaluing the readability benefits of consistent parameter handling patterns across a codebase. While consistency is good, this is too minor of a stylistic issue to warrant a PR comment. The code is clear as-is and works correctly. This comment should be removed as it addresses a purely stylistic preference without identifying any actual problems or important improvements.

4. src/app.rs:388

• Draft comment:
  Matching on *bypass && *confirmed for execution info is consistent. Verify that all parts handle booleans as references appropriately to avoid confusion.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that all parts handle booleans as references appropriately, which is against the rules. It does not provide a specific suggestion or point out a specific issue in the code.

5. src/database/mysql.rs:50

• Draft comment:
  The start_query implementation correctly bypasses parsing when bypass_parser is true (returns (query, None)). This pattern is consistent across drivers.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50% None

6. src/components/editor.rs:169

• Draft comment:
  Editor now distinguishes between normal and bypass submission via the new action. This clear separation is well done.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

7. src/popups/confirm_bypass.rs:23

• Draft comment:
  The ConfirmBypass popup correctly handles Y/N keys and produces the expected payload. The UI integration is solid.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

8. src/popups/confirm_query.rs:36

• Draft comment:
  Usage of statement_type_string(Some(*statement.clone())) is acceptable, but consider reducing unnecessary cloning or dereferencing for clarity.
• Reason this comment was not posted:
  Confidence changes required: 30% <= threshold 50% None

9. src/popups/confirm_tx.rs:41

• Draft comment:
  ConfirmTx popup now accepts an Option, aligning with the new design. The handling of None and message formatting is clear.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

10. src/popups/mod.rs:19

• Draft comment:
  PopUpPayload enum updated with ConfirmBypass variant – integration looks solid.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_QTRNtStZMjXSkHzt

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

Included in release v0.3.4