feat(마이페이지): 내 정보 조회 및 수정 페이지 UI 통일 #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIMSEUNGGYU
reviewed
Dec 10, 2024
| <input | ||
| ref={ref} | ||
| id={id} | ||
| className={cn(inputStyle, inputClassName)} |
There was a problem hiding this comment.
Suggested change
| className={cn(inputStyle, inputClassName)} | |
| className={cn(inputStyle, inputClassName, className)} |
상위 props 에서 className 을 �선언해서 위와 같이 사용하면 사용할때 className 으로 전달한 스타일이 적용되는 구조로 하면 확장성있는 구조가 될거 같습니다
There was a problem hiding this comment.
input 태그한테는 그게 inputClassName 이 그역할을 하긴 합니다. p Tag 에는 그 역할이 현재는 필요 없어요
그래도 일단 p 태그한테는 추가했습니다!
frontend/zicdding-class.com/app/(user)/my/_components/MyInfo.tsx
Outdated
Show resolved
Hide resolved
|
요새 잠을 주말에도 4시간 씩 자서 지금이라도 올렸습니다..! ㅠㅠ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-12-09.12.31.35.mov