feature: 클래스 리스트 페이지 기능 구현 (API MOCK) #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/class-card-list
…o refactor/class-card-fsd
- nextjs 의 pages 폴더는 route 방식으로 동작해서 fsd 의 pages layer 와 충돌나서 발생한 이슈
…o feat/class-list-api-mock
…o feat/class-list-api-mock
- useSearchParams 를 사용하는 곳에서는 Suspense 를 사용해야해서 수정
|
|
||
| const [localSearchValue, setLocalSearchValue] = useState(''); | ||
|
|
||
| const sortType = (searchParams.get('sortType') as SortType) ?? 'popular'; |
There was a problem hiding this comment.
런타임에서 문자열을 얻는건데 요렇게 as 로 타이핑해도 될까유?
There was a problem hiding this comment.
음.. 타입 좁힐려고 + 탭으로 제어한다고 생각했는데, 유저가 URL 을 직접 변경하면 런타임중에 타입이 유효하지 않은데 유효하다고 인식하겠네요.
그래서 타입 단언 부분 제거했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업
구현 UI
Screen.Capture.from.Scre.io.webm