feat : IT News 리스트 페이지 UI #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIMSEUNGGYU
reviewed
Nov 10, 2024
| <Card className="relative w-[400px] rounded-[20px] border border-black"> | ||
| <CardHeader className="relative w-full pb-56 rounded-tl-[20px] rounded-tr-[20px] overflow-hidden"> | ||
| <Card className="relative w-[calc(33.33%-26.667px)] rounded-[20px] border border-black"> | ||
| <CardHeader className="relative w-full pb-56 pt-0 rounded-tl-[20px] rounded-tr-[20px] overflow-hidden"> | ||
| <Image src={thumbnailSrc} alt={title} layout="fill" /> | ||
| </CardHeader> | ||
| <Link href={`/news/${id}`}> |
There was a problem hiding this comment.
해당 부분에 Link 가 있으면 (찜하기? 즐겨찾기?) 별표 아이콘 클릭할때 해당 이벤트가 발생하지 않고, 더 나아가서 해당 컴포넌트 재사용성이 떨어질거 같아요!
현재 제가 main 페이지에서 해당 컴포넌트 재사용하려는데 재사용성이 떨어지는거 같아서 해당 부분은 외부에 위임하는게 좋을거 같아요!!
|
네 확인해주셔서 감사합니다! |
KIMSEUNGGYU
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IT News 리스트 페이지 UI