Build/Test Tools: Improve dev environment's CLI in speed, non-interactive usage, and argument handling #8969
- Loading branch information
There are no files selected for viewing
Unchanged files with check annotations Beta
| test.beforeEach( async () => { | ||
| wpConfigOriginal = readFileSync( wpConfig, 'utf-8' ); | ||
| // Changing the table prefix tricks WP into new install mode. | ||
| writeFileSync( | ||
|
Check failure on line 24 in tests/e2e/specs/install.test.js
|
||
| wpConfig, | ||
| wpConfigOriginal.replace( `$table_prefix = 'wp_';`, `$table_prefix = 'wp_e2e_';` ) | ||
| ); | ||
| } ); | ||
| test.afterEach( async () => { | ||
| writeFileSync( wpConfig, wpConfigOriginal ); | ||
|
Check failure on line 31 in tests/e2e/specs/install.test.js
|
||
| } ); | ||
| test( 'should install WordPress with pre-existing database credentials', async ( { page } ) => { | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
wpis removed here because previously the entrypoint would inject it if it was missing: https://github.com/WordPress/wpdev-docker-images/blob/becc6740684d6ff6414d6539df040633b5ac5794/entrypoint/entrypoint-cli.sh#L16-L17With this PR, the
wpis always assumed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is technically a breaking change, I searched github for
npm run env:cli wpand there is only one reference which seems to be from a fork of a demo rather than actual production code, but it still might be worth a PR there after this lands and a quick note in the core room so folks are aware. I don't think it needs a dev note though since this isn't a public API.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR opened: Antonin06/wc-bretagne-2024#1