-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve env:install command with better configurability and error handling #8931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change, otherwise this looks good to me.
Co-authored-by: Aaron Jorbin <[email protected]>
…into trac-63543
Trac ticket: https://core.trac.wordpress.org/ticket/63543
wp-config.php
in the directory above thesrc
directory via theWP_CONFIG_PATH
environment variable read by WP-CLI in thewp_locate_config()
function.env:install
command to write out the config at the repo root instead of writing it inside of theABSPATH
only then to move it one directory up.npm run env:install
is executed without having first donenpm run env:start
(which has tripped me up multiple times), in which case the script will end with an exit code of 1 and emit:Commit Message
Build/Test Tools: Improve
env:install
command with better configurability and error handling.wp-config.php
in the directory above thesrc
directory via theWP_CONFIG_PATH
environment variable read by WP-CLI in thewp_locate_config()
function.env:install
command to write out the config at the repo root instead of writing it inside of theABSPATH
only then to move it one directory up.npm run env:install
is executed without having first donenpm run env:start
(which has tripped me up multiple times), in which case the script will end with an exit code of 1 and emit:Fixes #63543.
Props westonruter, jorbin, SirLouen.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.