Ensure URL Metric is initially constructed with all elements prior to initializing extensions #1968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #1951.
When testing the plugin I noticed an error in the console:
The error coming from the Intrinsic Dimensions extension started occurring after westonruter/od-intrinsic-dimensions#4 where I updated it to use
initialize
instead offinalize
since it was deprecated in #1951 in order to facilitate gzip compression in #1959. However, I realized that the location where extensions are initialized means that they cannot callextendElementData()
because the URL Metric object has not been populated yet with itselements
. This causes calls toextendElementData()
to always fail if they are performed while theinitialize()
function is being called (and not after a delay, for example).The fix is simply to move the extension initialization logic after the URL Metric data has been initially constructed with all of the tags (
elements
) being tracked.