-
Notifications
You must be signed in to change notification settings - Fork 128
Enhancement: Amend URL metrics to the generator meta tag content #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Amend URL metrics to the generator meta tag content #1954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1954 +/- ##
==========================================
+ Coverage 72.26% 72.33% +0.07%
==========================================
Files 85 85
Lines 6958 6976 +18
==========================================
+ Hits 5028 5046 +18
Misses 1930 1930
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
… enhancement/add-meta-generator-tag-for-optimization-dectective
@@ -2,6 +2,8 @@ | |||
<head> | |||
<meta charset="utf-8"> | |||
<title>...</title> | |||
<meta data-od-replaced-content="optimization-detective 0.0.0" name="generator" content="optimization-detective 0.0.0; url_metric_groups={0: complete, 480: complete, 600: complete, 782: complete}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the data-od-replaced-content
attribute is not ideal. This will have to be addressed in a separate issue, however: #1931 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nani-samireddy, LGTM!
Summary
Fixes #1953
Relevant technical choices
Updated the function
od_optimize_template_output_buffer
to include the URL metric groups data in the generator's META tag.This adds additional information about each breakpoint's minimum viewport width and the corresponding URL metrics status for that viewport group.
The generator's META tag is updated from:
to: