Skip to content

Improve formatting of .json and .yml files #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f101786
Formats json and yml files using npm run format
devansh016 Oct 18, 2024
3fed57a
Adds override config for yml and json
devansh016 Oct 18, 2024
eaaa59d
Formats json and yml files
devansh016 Oct 18, 2024
a3ae0e1
Add singleQuote for yml files
devansh016 Oct 18, 2024
d336d2a
Ignores generated lock files
devansh016 Oct 18, 2024
90ac758
Updates .editorconfig as per core and Gutenberg
devansh016 Oct 21, 2024
1d13a44
Formats using npm run format-js
devansh016 Oct 21, 2024
a565773
Updates patterns to ignore
devansh016 Oct 21, 2024
afc3339
Overides .yml config to use 2 spaces
devansh016 Oct 21, 2024
4a9d135
Adds file end line and update WordPress coding standards URL
devansh016 Oct 21, 2024
f9a6838
Merge branch 'trunk' of github.com:devansh016/wp-performance into For…
devansh016 Oct 28, 2024
6773f8e
Merge branch 'Format-files-using-npm-run-format-js' of github.com:dev…
devansh016 Oct 28, 2024
376b0fd
Merge branch 'trunk' of github.com:devansh016/wp-performance into For…
devansh016 Nov 19, 2024
9356e5a
Removes yml file override from prettier config
devansh016 Nov 19, 2024
9f687fd
Merge branch 'trunk' into Format-files-using-npm-run-format-js
devansh016 Jun 3, 2025
278fd9a
Merge branch 'trunk' into Format-files-using-npm-run-format-js
devansh016 Jun 6, 2025
3432198
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter Jun 10, 2025
981e5e5
Update package-lock.json
westonruter Jun 10, 2025
7c0f56c
Ignore build files in plugins and fix path to ignore minified files
westonruter Jun 10, 2025
d59caf6
Remove duplicate prettier config file
devansh016 Jun 10, 2025
ebeefd3
Update indent size to 4 for yml and yaml
devansh016 Jun 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicate prettier config file
devansh016 committed Jun 10, 2025
commit d59caf6a9b4b184301da86abdea9ed168a471acf
7 changes: 0 additions & 7 deletions .prettierrc.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this any different than the .prettierrc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, functionally they're identical in this case. Both .prettierrc.js and .prettierrc contain the same configuration options and produce the same formatting results.
We can remove .prettierrc.js here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, it could be added to package.json:

"prettier": "@wordpress/prettier-config",

This file was deleted.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@
"typescript": "^5.8.3",
"webpackbar": "^7.0.0"
},
"prettier": "@wordpress/prettier-config",
"scripts": {
"changelog": "./bin/plugin/cli.js changelog",
"since": "./bin/plugin/cli.js since",