-
Notifications
You must be signed in to change notification settings - Fork 128
Improve formatting of .json
and .yml
files
#1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devansh016
wants to merge
21
commits into
WordPress:trunk
Choose a base branch
from
devansh016:Format-files-using-npm-run-format-js
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25,285
−25,291
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f101786
Formats json and yml files using npm run format
devansh016 3fed57a
Adds override config for yml and json
devansh016 eaaa59d
Formats json and yml files
devansh016 a3ae0e1
Add singleQuote for yml files
devansh016 d336d2a
Ignores generated lock files
devansh016 90ac758
Updates .editorconfig as per core and Gutenberg
devansh016 1d13a44
Formats using npm run format-js
devansh016 a565773
Updates patterns to ignore
devansh016 afc3339
Overides .yml config to use 2 spaces
devansh016 4a9d135
Adds file end line and update WordPress coding standards URL
devansh016 f9a6838
Merge branch 'trunk' of github.com:devansh016/wp-performance into For…
devansh016 6773f8e
Merge branch 'Format-files-using-npm-run-format-js' of github.com:dev…
devansh016 376b0fd
Merge branch 'trunk' of github.com:devansh016/wp-performance into For…
devansh016 9356e5a
Removes yml file override from prettier config
devansh016 9f687fd
Merge branch 'trunk' into Format-files-using-npm-run-format-js
devansh016 278fd9a
Merge branch 'trunk' into Format-files-using-npm-run-format-js
devansh016 3432198
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter 981e5e5
Update package-lock.json
westonruter 7c0f56c
Ignore build files in plugins and fix path to ignore minified files
westonruter d59caf6
Remove duplicate prettier config file
devansh016 ebeefd3
Update indent size to 4 for yml and yaml
devansh016 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove duplicate prettier config file
commit d59caf6a9b4b184301da86abdea9ed168a471acf
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this any different than the
.prettierrc
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, functionally they're identical in this case. Both .prettierrc.js and .prettierrc contain the same configuration options and produce the same formatting results.
We can remove
.prettierrc.js
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, it could be added to
package.json
: