Try/block bindings use default for generic bindings #71002
Draft
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Experimental
|
The next question to answer will be how the source (i.e. |
|
Size Change: -24 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
One thing to consider would be e.g. how the Featured Image block currently fetches a post's featured image, and how it maps the latter's properties to its attributes -- especially considering that in the long run, it should be possible to express the Featured Image block as an Image block bound to the |
The Featured Image block is dynamic, so everything is handled with the gutenberg/packages/block-library/src/cover/index.php Lines 48 to 64 in 4171f27 |
When connecting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Experiment, based on some internal discussions with @cbravobernal and @gziolo.
Extend the mechanism that currently maps the
__defaultblock binding for pattern overrides to any kind of block binding. In other words, if an image block (whose supported attributes areid,url,title, andalt) has block bindings as follows:{ "__default":{"src":"core/post-data","args":{"key":"featuredMedia"}} }they are expanded into
{ "alt":{"src":"core/post-data","args":{"key":"featuredMedia"}}, "id":{"src":"core/post-data","args":{"key":"featuredMedia"}}, "title":{"src":"core/post-data","args":{"key":"featuredMedia"}}, "url":{"src":"core/post-data","args":{"key":"featuredMedia"}} }Why?
To explore a straightforward way and syntax of binding a block to a non-primitive source object (e.g. an image).
How?
TBD
Testing Instructions
TBD