Block support: Preserve anchor value in comment delimiter #70993
+135
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Enhancement
t-hamano
commented
Jul 31, 2025
| @@ -91,7 +86,7 @@ function BlockEditAnchorControlPure( { anchor, setAttributes } ) { | |||
| onChange={ ( nextValue ) => { | |||
| nextValue = nextValue.replace( ANCHOR_REGEX, '-' ); | |||
| setAttributes( { | |||
| anchor: nextValue, | |||
| anchor: nextValue !== '' ? nextValue : undefined, | |||
There was a problem hiding this comment.
This is necessary to avoid storing an empty string in comment delimiters. Also, without this change, some unit tests would fail.
t-hamano
commented
Jul 31, 2025
| @@ -14,7 +14,7 @@ export function createListBlockFromDOMElement( listElement ) { | |||
| const type = listElement.getAttribute( 'type' ); | |||
| const listAttributes = { | |||
| ordered: 'OL' === listElement.tagName, | |||
| anchor: listElement.id === '' ? undefined : listElement.id, | |||
| anchor: listElement.id ? listElement.id : undefined, | |||
There was a problem hiding this comment.
Without making this change, the mobile unit tests will fail. See: http://github.com/WordPress/gutenberg/actions/runs/16643294936/job/47097872501
t-hamano
requested review from
a team,
aristath and
noisysocks
and removed request for
a team
t-hamano
requested review from
tellthemachines,
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Jul 31, 2025
|
@youknowriad Thanks for the review! There may be differing opinions on the approach, so I'll leave it open until next week to see if there's any additional feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR does two things to enable dynamic blocks to support the
anchorattribute in the future:anchorattributes to always store values as comment delimiters.Why?
My first attempt was to extend the anchor support and allow you to decide whether or not to save an attribute as a comment delimiter (See #48438 (comment)).
However, rather than doing that heavy lifting, I thought it would be best to always store the value in the comment attribute, regardless of how the block is stored, similar to how class names and aliases are supported.
How?
applyBuiltInValidationFixesfor built-in validation fixes. This function contains the code to migrate the previousclassNameandariaLabelsupport to the new schema. I added the migration code for the anchor support here.Note: Dynamic block anchor support doesn't yet work with just this PR. As with aria-label support, some work needs to be done to inject IDs into the rendered HTML. This issue also requires a core backport PR, so I'll address it in #70995 as a follow-up.
Testing Instructions
Check out the
trunkbranch and insert some blocks with IDs:Check out this branch and reload the post. The sblock should not break.
Make changes to the content. The HTML will be updated to look like this: