Skip to content

Post Terms: Removing wp_kses_post causing issue #70991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jul 30, 2025

What?

Fixes: #68742
Follow up: #68810

#68810 has not seen any activity for several months, so I will follow up and resolve the issues.

Why?

The bg color of the prefix and suffix format is different from the normal display.

How?

Removing wp_kses_post which causing the issue.

As mentioned in this #40803

This probably isn't really necessary, but for consistency with the other blocks that have RichText fields and server-render those fields, I thought we could add it in. (Happy to close this out if folks think it doesn't need it).

Testing Instructions

  1. Open a post or page.
  2. Insert a Post Terms block.
  3. Set the Prefix to a Color from the toolbar.
  4. When you look at the front you can see that the Background is not being rendered.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before after

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: kartikmehta8 <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Post Terms Affects the Post Terms Block labels Jul 31, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jul 31, 2025

Thanks for the PR!

Removing the wp_kses_post function may solve the symptoms, but the underlying problem remains. Let's solve the problem with the wp_kses_post function itself.

See #68742 (comment) for more details.

@t-hamano t-hamano closed this Jul 31, 2025
@shimotmk shimotmk deleted the fix/post-term/68742 branch July 31, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Terms Affects the Post Terms Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Terms block: The color of the prefix and suffix format is different from the normal display
2 participants