Add View button to navigation link blocks #70986
Open
+98
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
commented
Jul 30, 2025
getdave
added
[Block] Navigation
|
Size Change: +251 B (+0.01%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
- Move View button implementation from navigation-link block to editor hook - Create navigation-link-view-button.js hook following pattern-overrides.js pattern - Hook targets core/navigation-link and core/navigation-submenu blocks - Use __unstableBlockToolbarLastItem to position button as last item - Remove router dependency issues by using editor hook context - Register hook in editor hooks index
- Replace router-based navigation with editor's onNavigateToEntityRecord - Add conditional focusMode support to onNavigateToEntityRecord - Disable focusMode for View button navigation for better UX - Maintain backwards compatibility for existing usage - Only show View button when block is selected
- Add type === 'page' condition to restrict View button to pages only - Prevents button from appearing on other post types (books, posts, etc.) - Maintains existing behavior for custom links (no button shown)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 8d53012. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16644768560
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a "View" button to the block toolbar for navigation link blocks that represent Pages (only). When clicked, the button navigates to the corresponding page in edit mode within the current editor context.
Note this doesn't not support other post types but could be extended to do so in the future if necessary.
Why
This enhancement improves the user experience by allowing quick navigation to pages while maintaining the editing workflow. Users can now easily jump to different pages without losing their current editing context or unsaved changes.
How
onNavigateToEntityRecordto navigate within the editoronNavigateToEntityRecord Enhancement
The
onNavigateToEntityRecordfunction has been enhanced to support conditionalfocusModeparameter handling:focusMode: true)focusMode: falseis explicitly passed, the parameter is entirely removed from the URL query stringfocusMode: falseto show the full editor interface rather than just the focused content areaTesting
Screenshots