Global Styles: Respect global border radius opt-out for button block #70984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #56626
This PR ensures that
core/button
block default settings ofborder.radius
do not override a theme's explicit intent when global support forborder
is disabled.Why?
Currently, if a theme sets
settings.border.radius
to false, thecore/button
block still shows the border radius UI because core provides a default of true for that block. This leads to confusing behavior where the global opt-out isn't fully respected unless the theme also disables the block level setting manually.How?
resolve_core_block_default_conflicts()
called inget_merged_data()
core/button
setting comes only from core (not overridden by theme).core/button.border.radius
is unset.Testing Instructions
theme.json
:Screenshots or screencast
Using the above provided config for
theme.json