Skip to content

Added max-width to DataView columns #70983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 1, 2025
+28 −31
Merged

Added max-width to DataView columns #70983

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
10b4c1e
Added max-width to DataView columns
rcrdortiz Jul 30, 2025
0456298
Fixed unit test
rcrdortiz Jul 31, 2025
5daef5c
Remove committed .idea directory
rcrdortiz Jul 31, 2025
5121695
Resotred the actual fix
rcrdortiz Jul 31, 2025
f4c353d
Added a min width for the first column
rcrdortiz Jul 31, 2025
86e8f99
Added a min-width to non Title columns so that we can display basic d…
rcrdortiz Jul 31, 2025
1c6163c
Added a primary column class and vertically aligned the row checkbox
rcrdortiz Jul 31, 2025
b315526
Adjusted the min width so that a column can fit any human readable da…
rcrdortiz Jul 31, 2025
0485dc5
We only add the large cell classes when the title cell contains the d…
rcrdortiz Jul 31, 2025
9c9850c
Super minor performance improvemnt in determining if we have a primar…
rcrdortiz Jul 31, 2025
a19bc11
Removed custom style from the Templates DataView
rcrdortiz Jul 31, 2025
5d90fa5
Restored action column max and min widths
rcrdortiz Jul 31, 2025
1158ab9
Increased max width for Title with description column so that it can …
rcrdortiz Jul 31, 2025
2388deb
Removed unnecessary span
rcrdortiz Jul 31, 2025
2510737
Fix min/max widths for primary columns
youknowriad Aug 1, 2025
ab6cd36
Update packages/dataviews/CHANGELOG.md
rcrdortiz Aug 1, 2025
c175184
Exclude the primary column media part from having a min-width. Restor…
rcrdortiz Aug 1, 2025
8273ebd
Changed max-width from 60ch to 90ch
rcrdortiz Aug 1, 2025
996dd49
Set max width to 80ch
youknowriad Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/dataviews/src/components/dataviews/stories/fixtures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ export const data: SpaceObject[] = [
{
id: 1,
title: 'Moon',
description: "Earth's satellite",
description:
'The Moon is Earth’s only natural satellite, orbiting at an average distance of 384,400 kilometers with a synchronous rotation that leads to fixed lunar phases as seen from Earth. Its cratered surface and subtle glow define night skies, inspiring exploration missions and influencing tides and biological rhythms worldwide.',
image: 'https://live.staticflickr.com/7398/9458193857_e1256123e3_z.jpg',
type: 'Satellite',
isPlanet: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/dataviews/src/dataviews-layouts/table/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
td,
th {
padding: $grid-unit-15;
white-space: nowrap;
max-width: 60ch;

&.dataviews-view-table__actions-column {
text-align: right;
Expand Down
6 changes: 4 additions & 2 deletions packages/dataviews/src/test/filter-and-sort-data-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ describe( 'filters', () => {
fields
);
expect( result ).toHaveLength( 2 );
expect( result[ 0 ].description ).toBe( "Earth's satellite" );
expect( result[ 0 ].description ).toBe(
'The Moon is Earth’s only natural satellite, orbiting at an average distance of 384,400 kilometers with a synchronous rotation that leads to fixed lunar phases as seen from Earth. Its cratered surface and subtle glow define night skies, inspiring exploration missions and influencing tides and biological rhythms worldwide.'
);
} );

it( 'should perform case-insensitive and accent-insensitive search', () => {
Expand Down Expand Up @@ -422,7 +424,7 @@ describe( 'filters', () => {
fields
);
expect( result.map( ( r ) => r.description ) ).toEqual( [
"Earth's satellite",
'The Moon is Earth’s only natural satellite, orbiting at an average distance of 384,400 kilometers with a synchronous rotation that leads to fixed lunar phases as seen from Earth. Its cratered surface and subtle glow define night skies, inspiring exploration missions and influencing tides and biological rhythms worldwide.',
'Moon of Jupiter',
'Moon of Jupiter',
'La planète Vénus',
Expand Down
Loading