Lower PostPanelRow style specifity
#70981
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
alshakero
added
[Type] Bug
|
Size Change: -8 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
t-hamano
added
the
General Interface
t-hamano
reviewed
Jul 31, 2025
There was a problem hiding this comment.
Thanks for the PR!
I do know removing them resolves the issue in my editor instance (consumed from packages/editor) as shown in the screenshot below.
I'm not sure why this PR will solve the issue in your environment, but I think we can remove these styles altogether.
Instead, we can add the alignment styles here:
gutenberg/packages/editor/src/components/post-panel-row/index.js
Lines 14 to 17 in b860887
That is, make the following changes:
diff --git a/packages/editor/src/components/post-panel-row/index.js b/packages/editor/src/components/post-panel-row/index.js
index 71dd63d3c0..243989744f 100644
--- a/packages/editor/src/components/post-panel-row/index.js
+++ b/packages/editor/src/components/post-panel-row/index.js
@@ -14,6 +14,7 @@ const PostPanelRow = forwardRef( ( { className, label, children }, ref ) => {
<HStack
className={ clsx( 'editor-post-panel__row', className ) }
ref={ ref }
+ align="flex-start"
>
{ label && (
<div className="editor-post-panel__row-label">{ label }</div>
diff --git a/packages/editor/src/components/post-panel-row/style.scss b/packages/editor/src/components/post-panel-row/style.scss
index 53e0c645f6..23ab5eb1e5 100644
--- a/packages/editor/src/components/post-panel-row/style.scss
+++ b/packages/editor/src/components/post-panel-row/style.scss
@@ -1,8 +1,6 @@
.editor-post-panel__row {
width: 100%;
min-height: $grid-unit-40;
- justify-content: flex-start !important;
- align-items: flex-start !important;
}
.editor-post-panel__row-label {Can you try this?
|
Hi @t-hamano! Thank you so much for the review. I tried it and I still had the same issue. But I extended the fix and things are good now. Here's what was happening:
I considered using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This removes the overpowering
!importantfrom alignment and justification values of.editor-post-panel__row. They were added in #56319 but I couldn't decipher why. And frankly I'm not 100% sure what are the wider implications of removing them. I do know removing them resolves the issue in my editor instance (consumed frompackages/editor) as shown in the screenshot below.Why?
To align the grid better.
How?
Reverting part of #56319
Testing Instructions
TBD
Testing Instructions for Keyboard
Doesn't apply.
Screenshots or screencast