Block Editor: Fix single block selection when holding 'Shift' key #70978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Block Multi Selection
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Jul 30, 2025
Comment on lines
-294
to
-296
| // To do: run with iframe. | ||
| await editor.switchToLegacyCanvas(); | ||
|
|
There was a problem hiding this comment.
Test works without requiring a non-iframed canvas.
|
Size Change: +2 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jul 30, 2025
|
Thanks, @tyxla! I'm going to merge this and continue debugging the recently discovered regression by Playwright. |
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Jul 31, 2025
…rdPress#70978) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a regression of #34137.
PR fixes a regression in the
useClickSelectionhook when theshiftKeymodifier is used.It looks like this regressed a while ago, but only started failing with the recent Playwright upgrade (#70503). The bug is easy to reproduce consistently when testing manually.
Why?
Allows for easy editing of a single selected block without needing to clear multi-selection.
How?
Same as #34137. Confirm that the start client ID exists before triggering multi-selection.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before
CleanShot.2025-07-30.at.16.15.28.mp4
After
CleanShot.2025-07-30.at.16.14.08.mp4