Fix: Global Styles: Font Appearance doesn't work well with theme.json default value #70976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for accurate results
6 tasks
hbhalodia
commented
Jul 30, 2025
Comment on lines
+42
to
+57
| const fontWeightMapping = { | ||
| thin: 100, | ||
| 'extra light': 200, | ||
| 'extra-light': 200, | ||
| light: 300, | ||
| regular: 400, | ||
| medium: 500, | ||
| 'semi bold': 600, | ||
| 'semi-bold': 600, | ||
| bold: 700, | ||
| 'extra bold': 800, | ||
| 'extra-bold': 800, | ||
| black: 900, | ||
| 'extra black': 1000, | ||
| 'extra-black': 1000, | ||
| }; |
There was a problem hiding this comment.
Not sure, is this the ideal approach, or do we have this object mapping present somewhere else so we can utilize that? @t-hamano
hbhalodia
commented
Jul 30, 2025
Comment on lines
+207
to
+211
| // Check if newFontWeightValue is not a numeric number, but it is a valid string. | ||
| if ( isNaN( parseInt( newFontWeightValue ) ) ) { | ||
| newFontWeightValue = fontWeightMapping[ newFontWeightValue ] ?? '100'; | ||
| } | ||
|
|
There was a problem hiding this comment.
This would needed because, else the comparision and difference would always be on NaN value, hence it always uses 100 at the end.
t-hamano
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70937
Why?
How?
Testing Instructions
BoldfontWeight would be selected.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2025-07-30.at.4.11.21.PM.mov