Pullquote: Try adding Block Bindings support #70975
Draft
+66
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Block] Pullquote
gziolo
commented
Jul 30, 2025
Comment on lines
+13
to
+15
| const hasBoundCitation = !! metadata?.bindings?.citation; | ||
| const shouldShowCitation = | ||
| hasBoundCitation || ! RichText.isEmpty( citation ); |
There was a problem hiding this comment.
@cbravobernal, circling back to our chat earlier this week, this check allows us not to render the cite tag when the binding is not set, making the save function fully backward compatible.
gziolo
commented
Jul 30, 2025
| $block_type->uses_context = array_merge( $block_type->uses_context, $value_binding_source->uses_context ); | ||
| $block_instance->refresh_context_dependents(); | ||
| $value = $value_binding_source->get_value( $value_args, $block_instance, 'value' ); | ||
| $block_reader->set_attribute( 'data-value', $value ); |
There was a problem hiding this comment.
The final solution should use set_inner_html once it is implemented.
|
Size Change: +96 B (+0.01%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
Part of #67520.
Still work in progress.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast