Try adding optional infinite scroll to dataviews #70955
Draft
+175
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +421 B (+0.02%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
No particular reason apart from it being a more common UI pattern in that type of view, but given it's an opt-in it should be fine to add it for all views. |
|
Thanks for the feedback Riad! I've updated to add infiniteScrollHandler inside paginationInfo and allow infinite scroll on all view types. There's still a few things that need to be added before the PR is ready; I'll continue working on it in the next few days. |
|
It'd be great to update the stories in the storybook so that it's testable there as well. It should hopefully be pretty easy to update the views: Possibly we might need a bigger data set in the stories. I thnk Jupiter and Saturn have some more moons that could be added 😄 |
tellthemachines
force-pushed
the
try/dataviews-infinite-scroll
branch
from
50af36d to
6e25cd6
Compare
How do I get those image URLs from |
|
Good question. I found this gallery which is creative commons - https://www.flickr.com/photos/lightsinthedark/albums/72157694956141104/ But I'm not sure how you get the links. edit: Actually, maybe not every image is creative commons, it seems only some, might be ok for our usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It's likely this will be needed as DataViews is adopted in more wp-admin screens.
This PR proposes adding an optional
infiniteScrollHandlerprop to the DataViews component. If this prop exists and is a function, an infinite scroll toggle is enabled in the view config for the grid layout type only (it could be expanded to other layout types if it makes sense to do so).To try this out, this PR also changes the PostList to pass an
infiniteScrollHandlerinto DataViews, so its functionality can be tested on the Pages screen (provided there are enough pages to trigger pagination).The PostList change doesn't need to be done in this PR, I just added it so it's easier to test. But the main question for now is whether this API is good.
Testing Instructions