TypeScript: Convert redux-store types in data package to TS #67666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
changed the title
|
Size Change: +3 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4c471dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12515974894
|
There was a problem hiding this comment.
Pull Request Overview
Convert JavaScript Redux store utilities in the data package to TypeScript to enable stronger typing across the store.
- Added typed versions of thunk middleware, action creators, reducer, and
combineReducers. - Removed the corresponding JavaScript files.
- Enhanced the reducer with a
defaultcase and streamlined action unions.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/data/src/redux-store/thunk-middleware.ts | Added TS version of thunk middleware |
| packages/data/src/redux-store/thunk-middleware.js | Removed JS version of thunk middleware |
| packages/data/src/redux-store/metadata/actions.ts | Added TS action creators with as const types |
| packages/data/src/redux-store/metadata/actions.js | Removed JS action creators |
| packages/data/src/redux-store/metadata/reducer.ts | Converted reducer to TS, added default case |
| packages/data/src/redux-store/combine-reducers.ts | Added TS-typed combineReducers implementation |
| packages/data/src/redux-store/combine-reducers.js | Removed JS combineReducers |
Comments suppressed due to low confidence (2)
packages/data/src/redux-store/metadata/reducer.ts:38
- The
StateKeytype is declared but not used anywhere. Removing it will reduce dead code and improve clarity.
type StateKey = unknown[] | unknown;
packages/data/src/redux-store/combine-reducers.ts:11
- [nitpick] Consider adding a JSDoc comment explaining this generic overload and its parameters, so future maintainers understand the intended usage and type behavior.
export function combineReducers< M >(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #66683, which got closed after I deleted my fork 🤦
What?
Convert JS files inside
packages/data/src/redux-storeto TSWhy?
To pave the way for fixing types for
dataandcore-datapackagesHow?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast