Skip to content

feat: APPS-3096 Assemble Filmmakers Listing page #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jul 25, 2025

Connected to APPS-3096

Page Updated: /pages/collections/la-rebellion/filmmakers/index.vue

Notes:

  • Assembled page components
  • Minor styling updates to other templates to keep breadcrumb positioning consistent
  • Updated Nuxt modules (1.2.39) and Design tokens (5.34.0) packages
  • Added Cypress test

Preview: https://deploy-preview-185--test-ftva.netlify.app/collections/la-rebellion/filmmakers/

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I have requested a PR review from the Dev team

@tinuola tinuola self-assigned this Jul 25, 2025
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Jul 25, 2025

🚀 Deployed on https://deploy-preview-185--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 21:29 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 21:48 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 22:21 Inactive
@tinuola tinuola force-pushed the APPS-3096_assemble-filmmaker-listing-page branch from 0fd13b6 to 867ce82 Compare July 25, 2025 22:36
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 22:41 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 22:50 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 22:55 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-185 July 25, 2025 23:04 Inactive
@tinuola tinuola force-pushed the APPS-3096_assemble-filmmaker-listing-page branch from d992950 to 2542fe1 Compare July 25, 2025 23:08
@tinuola tinuola marked this pull request as draft July 25, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant