Skip to content

feat: APPS-3097 Add Filmmakers Listing composable #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jul 22, 2025

Connected to APPS-3095, APPS-3097

Page updated: /pages/collections/la-rebellion/filmmaker/index.vue

Notes:

  • Update graphQL file to only return single entry content
  • Set up composable for LA Rebellion Filmmaker Listings data from ElasticSearch
  • Tested composable output

Preview: https://deploy-preview-183--test-ftva.netlify.app/collections/la-rebellion/filmmakers/

Checklist:

  • I added github label for semantic versioning
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I requested a PR review from the Dev team

@tinuola tinuola self-assigned this Jul 22, 2025
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Jul 22, 2025

🚀 Deployed on https://deploy-preview-183--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-183 July 22, 2025 21:33 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-183 July 22, 2025 22:22 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-183 July 22, 2025 22:47 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-183 July 24, 2025 21:04 Inactive
@tinuola tinuola force-pushed the APPS-3097_filmmakers-listing-composable branch from 81660de to 6c80247 Compare July 24, 2025 21:07
@tinuola tinuola force-pushed the APPS-3097_filmmakers-listing-composable branch from 6c80247 to 725331c Compare July 24, 2025 21:10
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@tinuola tinuola merged commit 878a2bf into main Jul 24, 2025
8 checks passed
@tinuola tinuola deleted the APPS-3097_filmmakers-listing-composable branch July 24, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants