#2897 Updating circle, ellipse, line-arc, and sector to use smarter approximations #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore accurate arc approximation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the details and linked post in #2897
The focus of this work is to update the
turf.circle(...)to use a smarter regular polygon approximation. Related packages have also been updated to use more accurate approximations includingellipse,line-arc, andsector. These packages should be as consistent with each other as the are in version 7.2.0.Please let me know if you find any issues or have any questions, I would be happy to assist if I can. Thanks for your help.
Tickets
closes #2897
Tests and Docs
All related tests and documentation have been updated.
Changes
The returned construction for all mentioned packages above will now differ from the current turf version (7.2.0). A new option,
options.maximumRimDeviation, is now available for some of the mentioned packages.Other