Skip to content

Bind button command to <ButtonRelease-1> for native-like behavior #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bind button command to <ButtonRelease-1> for native-like behavior #2736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions customtkinter/windows/widgets/ctk_button.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,14 @@ def _create_bindings(self, sequence: Optional[str] = None):
self._text_label.bind("<Button-1>", self._clicked)
if self._image_label is not None:
self._image_label.bind("<Button-1>", self._clicked)
if sequence is None or sequence == "<ButtonRelease-1>":
self._canvas.bind("<ButtonRelease-1>", self._on_release)

if self._text_label is not None:
self._text_label.bind("<ButtonRelease-1>", self._on_release)
if self._image_label is not None:
self._image_label.bind("<ButtonRelease-1>", self._on_release)


def _set_scaling(self, *args, **kwargs):
super()._set_scaling(*args, **kwargs)
Expand Down Expand Up @@ -544,14 +552,10 @@ def _click_animation(self):

def _clicked(self, event=None):
if self._state != tkinter.DISABLED:

# click animation: change color with .on_leave() and back to normal after 100ms with click_animation()
self._on_leave()
self._on_leave()
self._click_animation_running = True
self.after(100, self._click_animation)

if self._command is not None:
self._command()


def invoke(self):
""" calls command function if button is not disabled """
Expand Down Expand Up @@ -592,3 +596,14 @@ def focus_set(self):

def focus_force(self):
return self._text_label.focus_force()

def _on_release(self, event=None):
if self._state != tkinter.DISABLED:
x, y = event.x, event.y
width = self._canvas.winfo_width()
height = self._canvas.winfo_height()

if 0 <= x <= width and 0 <= y <= height:
if self._command is not None:
self._command()