Skip to content

Fixed: Scrollbar Covers The Borders In ScrollableFrame #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed: Scrollbar Covers The Borders In ScrollableFrame #2548

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d15393
Scrollbar padding fixed in scrollable frame.
dipeshSam Aug 20, 2024
e503e13
Refixed scrollbar padding in CTkScrollableFrame
dipeshSam Aug 20, 2024
f4a8109
Refixing the scrollbar of the scrollable frame.
dipeshSam Aug 20, 2024
e99f542
Fixed related bugs
dipeshSam Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions customtkinter/windows/widgets/ctk_scrollable_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def __init__(self,
# dimensions independent of scaling
self._desired_width = width # _desired_width and _desired_height, represent desired size set by width and height
self._desired_height = height
self._border_width = border_width if border_width else 0

self._parent_frame = CTkFrame(master=master, width=0, height=0, corner_radius=corner_radius,
border_width=border_width, bg_color=bg_color, fg_color=fg_color, border_color=border_color)
Expand Down Expand Up @@ -99,21 +100,23 @@ def _create_grid(self):
border_spacing = self._apply_widget_scaling(self._parent_frame.cget("corner_radius") + self._parent_frame.cget("border_width"))

if self._orientation == "horizontal":
border_padding = (0, self._border_width +1)
self._parent_frame.grid_columnconfigure(0, weight=1)
self._parent_frame.grid_rowconfigure(1, weight=1)
self._parent_canvas.grid(row=1, column=0, sticky="nsew", padx=border_spacing, pady=(border_spacing, 0))
self._scrollbar.grid(row=2, column=0, sticky="nsew", padx=border_spacing)
self._scrollbar.grid(row=2, column=0, sticky="nsew", padx=border_spacing, pady=border_padding)

if self._label_text is not None and self._label_text != "":
self._label.grid(row=0, column=0, sticky="ew", padx=border_spacing, pady=border_spacing)
else:
self._label.grid_forget()

elif self._orientation == "vertical":
border_padding = (0, self._border_width +1)
self._parent_frame.grid_columnconfigure(0, weight=1)
self._parent_frame.grid_rowconfigure(1, weight=1)
self._parent_canvas.grid(row=1, column=0, sticky="nsew", padx=(border_spacing, 0), pady=border_spacing)
self._scrollbar.grid(row=1, column=1, sticky="nsew", pady=border_spacing)
self._scrollbar.grid(row=1, column=1, sticky="nsew", padx=border_padding, pady=border_spacing)

if self._label_text is not None and self._label_text != "":
self._label.grid(row=0, column=0, columnspan=2, sticky="ew", padx=border_spacing, pady=border_spacing)
Expand Down Expand Up @@ -160,7 +163,8 @@ def configure(self, **kwargs):
self._create_grid()

if "border_width" in kwargs:
self._parent_frame.configure(border_width=kwargs.pop("border_width"))
self._border_width = kwargs.pop("border_width")
self._parent_frame.configure(border_width=self._border_width)
self._create_grid()

if "fg_color" in kwargs:
Expand Down