Avoid unintended side-effects on non-interactive library disassociations (PP-2408) #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/library-disassociation-confirmation
to
main
August 20, 2025 17:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use newly-added
isLibraryRemovalPermitted(instead ofremoveLibrary) to confirm interactive removals of library associations from collections.NB: This PR is ready for review; however, it depends on #170 for
isLibraryRemovalPermitted, so this PR should not be merged until that one is landed.Motivation and Context
Confirmation popups were rendering for each associated library when the
CollectionEditFormwas being cleared. This is becauseremoveLibraryis used both interactively -- when libraryDeletebutton is clicked -- and non-interactively, when the form is cleared.[Jira PP-2408]
How Has This Been Tested?
Checklist: