Skip to content

fix(panel): clarify Chat Memory asset ownership labels - #1988

Open
yuT7-blue wants to merge 5 commits into
TencentCloud:feat/server_teamfrom
yuT7-blue:fix/issue-1957-memory-owner-label
Open

yuT7-blue wants to merge 5 commits into
TencentCloud:feat/server_teamfrom
yuT7-blue:fix/issue-1957-memory-owner-label

Conversation

@yuT7-blue

@yuT7-blue yuT7-blue commented Nov 11, 2026 •

Copy link
Copy Markdown

Description | 描述

修正 Chat Memory 页面将资产所有者误标为“上传者”的展示问题,避免用户混淆资产归属与 L0/L1 对话来源。

主要修改:

  • 将中文“上传”修改为“资产归属用户”,英文改为 Asset owner。
  • 在详情页增加提示,说明 L0/L1 按用户隔离,L2/L3 按 Team + Agent 共享。
  • 同步更新中英文文案。

涉及文件:

  • MemoryPanel/web/src/i18n/zh-CN.ts
  • MemoryPanel/web/src/i18n/en-US.ts
  • MemoryPanel/web/src/pages/ChatMemoryPage/components/BlockDetail.tsx

本次仅修改 UI 文案和提示,不改变数据查询、权限及记忆处理逻辑。

Related Issue | 关联 Issue

Refs #1957

本 PR 仅处理资产归属标签容易产生误解的问题。

以下功能仍未解决:

  • 当前用户与团队成员的记忆筛选。
  • L0 计数与时间范围不一致的问题。
  • 上传回执中的归属说明。

因此本 PR 不关闭 #1957。

Change Type | 修改类型

  • Bug fix | Bug 修复
  • New feature | 新功能
  • Documentation update | 文档更新
  • Code optimization | 代码优化

Self-test Checklist | 自测清单

  • Verified locally | 本地验证通过
  • No existing features affected | 无影响现有功能(仅修改文案及提示)

已完成:

  • 检查 PR Diff,确认仅修改 3 个文件。
  • 静态检查中英文文案、国际化 key 和组件引用。

尚未执行:

  • 前端构建与 lint。
  • 自动化测试及浏览器交互测试。

Additional Notes | 其他说明

本次修改为 #1957 的局部修正。后续成员筛选及计数一致性问题需要独立设计和验证。

)

Signed-off-by: spring <238799810+yuT7-blue@users.noreply.github.com>
)

Signed-off-by: spring <238799810+yuT7-blue@users.noreply.github.com>
…ud#1957)

Signed-off-by: spring <238799810+yuT7-blue@users.noreply.github.com>
Signed-off-by: spring <238799810+yuT7-blue@users.noreply.github.com>
Signed-off-by: spring <238799810+yuT7-blue@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Thank you for your contribution! This is an automated acknowledgment. We'll review it internally soon and share all feedback in the discussion below.

@YOMXXX

YOMXXX commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

中文

@Maxwell-Code07 @YUAN1GUI 供评审参考:文案方向对得上,改动面也确认很小,有两点建议。

  1. 影响面可确认:memory.list.uploadedBy 在全仓只有 3 处命中(i18n/en-US.ts、i18n/zh-CN.ts、pages/ChatMemoryPage/components/BlockDetail.tsx),所以这次改文案只影响详情面板那一行,不会牵连其它页面。两个 locale 都补齐了,resources 里也只注册了 zh-CN / en-US 两种语言。

  2. 键名和新语义已经脱节:详情面板用的是 memory.list.uploadedBy(list 前缀的键)来渲染"资产归属用户"。现在文案改成 owner 语义,键名却还叫 uploadedBy,以后按名字找文案会误导。更干净的做法是新增 memory.detail.assetOwner,旧的 memory.list.uploadedBy 保持不动(当前没有其它调用点,成本很低)。

  3. tooltip 里的隔离范围建议补一个出处:新增的 memory.detail.ownerHint 断言了「L0/L1 按用户隔离,L2/L3 按团队与 Agent 共享」。我在 README_CN.md(第 264-273 行只描述 L0 Conversation→L1 Atom→L2 Scenario→L3 Persona 的粒度)、MemoryCore/README.md(第 181 行只提到 v3 是 strongly isolated 的 L0–L3 data plane)、MemoryCore/SKILL.md 里都没找到这句按层划分归属范围的表述。建议在 PR 描述里给出依据(代码位置或设计文档),或者把措辞收窄到「该字段记录的是资产归属用户,不一定等于每条 L0/L1 的发送者」——后半句是能从字段语义直接得到的,前半句需要有出处,否则隔离策略一改这句 tooltip 就先过期了。

English

@Maxwell-Code07 @YUAN1GUI for review: the wording change makes sense and the blast radius is confirmed small; two suggestions.

  1. Blast radius is verifiable: memory.list.uploadedBy has only three hits in the repo (i18n/en-US.ts, i18n/zh-CN.ts, pages/ChatMemoryPage/components/BlockDetail.tsx), so the text change only affects that one meta row in the detail panel. Both locales are covered, and only zh-CN / en-US are registered in the i18n resources.

  2. The key name no longer matches its meaning: the detail panel renders the "asset owner" label through memory.list.uploadedBy — a key with a list prefix. Renaming the text to owner semantics while keeping the uploadedBy key will mislead anyone looking the string up by name. Adding memory.detail.assetOwner and leaving memory.list.uploadedBy untouched would be cleaner (there are no other call sites, so it is cheap).

  3. The isolation claim in the tooltip needs a source: the new memory.detail.ownerHint asserts "L0/L1 are user-scoped; L2/L3 are shared by team and agent". I could not find that per-layer ownership statement in README_CN.md (lines 264-273 only describe the L0 Conversation → L1 Atom → L2 Scenario → L3 Persona granularity), MemoryCore/README.md (line 181 only says v3 is a strongly isolated L0–L3 data plane), or MemoryCore/SKILL.md. Please cite where it comes from (a code location or design doc) in the description, or narrow the wording to "this field records the asset owner, which is not necessarily the sender of every L0/L1 message" — the second half follows directly from the field, the first half needs a source. Otherwise the tooltip will go stale the first time the isolation policy changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants