Skip to content

adding error message to form app questionnaire #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 260 commits into
base: develop
Choose a base branch
from

Conversation

Vicwin13
Copy link
Collaborator

@Vicwin13 Vicwin13 commented Aug 7, 2025

📝 Description

Triggering of error messages to fields that are not selected or filled.

🔂 Changes Made

changes made in the internal script file

⚙️ Related Issue

🍏 Type of Change

  • Bug fix

🧰 New Environment Variables or Requirements

none

✅ Checklist

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have commented my code where necessary.
  • I have tested my code locally and verified the website is working as expected.

daaimah123 and others added 30 commits February 6, 2025 08:21
…hold templates with

add additional application routes and enhance questionnaire and household templates
…hold templates with improved tooltips and validation
Created Local Storage to Save User Progress
BrayanMQ and others added 22 commits July 23, 2025 14:24
Renamed validateForm() to validateHouseholdForm() to avoid function name conflict with other scripts.
[Issue 688] Refactor css app reference page
…-to-external-file

Feature/move household script to external file
Refactor app-reference.html to move <script> block into external Java…
…ainer when user selects any option

An event listener was added to the radio buttons so that when the user selects any option, the red border is automatically removed from the radio group container
[Issue 683] Refactor css app-form-details page
… duplicates

- Implemented usage of household.js functions in household.html
- Removed all duplicate functions from household.html
…iggering

[Issue 717] BugFix: Application Form /app-household.html Validation Errors Not Triggering Correctly
…s-to-external-file

Move Inline JS in long-text.html to External File
@Vicwin13 Vicwin13 requested a review from daaimah123 August 7, 2025 15:47
Copy link
Collaborator

@daaimah123 daaimah123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vicwin13 Please update this PR's based branch to be mvp and update your feature branch with mvp. At present this PR is adding in additional work that is actually present in the mvp branch, making much of this PR out of scope for the changes requested. Thank you.

develop to mvp

Please also be sure to push up your changes, as is I don't see any new commit history from you.

@Vicwin13
Copy link
Collaborator Author

Vicwin13 commented Aug 8, 2025

error

this is what I get @daaimah123

@daaimah123
Copy link
Collaborator

@Vicwin13 that error is saying that this PR does not contain any new work that is different from the mvp branch. In summary, we cannot have a PR that merges a cloned branch with no changes into the same branch, because they are the same.

Please push up your changes that were implemented onto your feature branch and then you will be able to change the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Form /app-questionnaire.html Form Validation Errors Not Triggering Correctly