Skip to content

fix: Banner Not Hiding Properly #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

epoll31
Copy link
Contributor

@epoll31 epoll31 commented Jul 6, 2024

Description

added appropriate overflow-hidden

Related Issue

Fixes #250

Proposed Changes

  • Added overflow-hidden to nearest ancestor element that contains relative since the Banner uses absolute.

Checklist

Please check the boxes that apply:

  • I have rebased my branch on top of the latest main branch.
  • I have tested the changes locally
  • I ran npm run build and build is successful
  • I have added necessary documentation (if applicable)
  • I have updated the credits.md file (if applicable)

@epoll31 epoll31 requested a review from Ansub as a code owner July 6, 2024 01:43
Copy link

vercel bot commented Jul 6, 2024

@epoll31 is attempting to deploy a commit to the SyntaxUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 10:09am

@epoll31 epoll31 mentioned this pull request Jul 6, 2024
5 tasks
@Ansub Ansub merged commit f776d41 into SyntaxUI:main Jul 7, 2024
2 of 3 checks passed
@Ansub Ansub added the enhancement New feature or request label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Banner Not Hiding Properly
2 participants