-
Notifications
You must be signed in to change notification settings - Fork 89
Added: Support for Pause and Resume #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Sewer56
wants to merge
7
commits into
main
Choose a base branch
from
native-pause-resume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking a thread when task is paused.
erri120
requested changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at the code, the main reason this alternative approach was implemented was to:
But the pausing approach proposed doesn't work well for our purposes because it
|
Added: ForcePauseExample Updated: README Pointing to Force-Pause Feature Updated: ForcePauseExample with further clarification
d3d18c5
to
1ae3e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job Pause/Resume Implementation
Spent a bit thinking about the problem; including how to best handle
requested upcoming features such as downloads pausing/resuming.
I think the solution here is decent; it's a bit different than originally proposed, which was a cancel/restart.
This is more of a true pause/resume, by stalling existing jobs without hogging the threadpool.
Summary
Adds pause/resume functionality to the job system using a cooperative model, with both standard and pre-emptive pause modes.
Jobs can be paused using existing
YieldAsync()
yield points and resumed later,with cancellation taking precedence over pause.
Main Points
JobCancellationToken
: New token combining cancellation + pause/resume usingAsyncManualResetEvent
YieldAsync()
: Now handles both pause detection and waiting for resumePause()
/Resume()
methods toIJob
,IJobGroup
,IJobMonitor
SupportsForcePause => true
and handleOperationCanceledException
withHandlePauseExceptionAsync()
Tests & Examples
Examples/BestPractices/PauseResumeExample.cs
Examples/BestPractices/ForcePauseExample.cs
JobCancellationToken
(e.g. Pausing, Waiting, etc.) inNexusMods.Jobs.Tests/Unit/JobCancellationTokenTests.cs
NexusMods.Jobs.Tests/Unit/JobPauseResumeTests.cs
NexusMods.Jobs.Tests/Unit/JobForcePauseResumeTests.cs
Misc
AsyncManualResetEvent
by hand.Tests were written with extra care to prevent flakiness in CI.
As we know, the Windows GitHub Actions test runner can be unreliable and stall several seconds at a time. So I've been very careful with how we wait.
fixes #3604