Support 1f1b a2a overlap #1671
Open
Support 1f1b a2a overlap #1671
+2,492
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2025 00:59
Signed-off-by: Hongbin Liu <[email protected]>
Signed-off-by: Hongbin Liu <[email protected]>
Skylion007
reviewed
Jul 7, 2025
| 'overlap_moe_expert_parallel_comm is only supported with alltoall/flex token dispatcher' | ||
|
|
||
| # Disable recomputation as it conflicts with overlap_moe_expert_parallel_comm's memory management | ||
| assert args.recompute_granularity != 'full', \ |
There was a problem hiding this comment.
What about recompute_granularity selective? Is that supported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.