Skip to content

Add DoobMatchingFlow #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

Add DoobMatchingFlow #8

merged 4 commits into from
Jul 10, 2025

Conversation

murrellb
Copy link
Member

@murrellb murrellb commented Jul 7, 2025

No description provided.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 14.87%. Comparing base (b4525f7) to head (d300d36).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/doob.jl 0.00% 39 Missing ⚠️
src/bridge.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   17.20%   14.87%   -2.33%     
==========================================
  Files           6        7       +1     
  Lines         250      289      +39     
==========================================
  Hits           43       43              
- Misses        207      246      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@murrellb
Copy link
Member Author

murrellb commented Jul 9, 2025

Related: https://arxiv.org/pdf/2310.16834
Also noted in Generator Matching paper, and should be a special case of that.

@murrellb
Copy link
Member Author

Likely related to Campbell et al 2024 too?

@AntonOresten
Copy link
Member

The example runs. I don't know what a Doob is but the example runs..

image

@AntonOresten
Copy link
Member

Why is the closed form of doob_guide only applicable to PiQ, UniformUnmasking, and UniformDiscrete? @murrellb

@murrellb
Copy link
Member Author

Why is the closed form of doob_guide only applicable to PiQ, UniformUnmasking, and UniformDiscrete? @murrellb

Most of our processes don't construct an explicit Q matrix, and the closed form for Doob needs rows of the rates in the Q matrix (as well as a backward call). Those processes are the ones I worked through for this. I guess I ignored the process that actually does have a Q matrix, which would be trivial to do, so that could be added (even though it is less useful, generally).

@murrellb murrellb merged commit 76112c0 into main Jul 10, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants