Skip to content

Conversation

@kgooris
Copy link

@kgooris kgooris commented Nov 4, 2025

Hi, I'm a working Employee from TrendMiner, we want to update the urls as you can see in the pull request.
In case of issue or problems with this request, please reachout.

@prmerger-automator
Copy link
Contributor

@kgooris : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit f7e687e:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/trendminer-tutorial.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards v-dirichards requested a review from Copilot November 4, 2025 15:56
@v-dirichards
Copy link
Contributor

@nguhiu

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TrendMiner SAML configuration URLs in the tutorial documentation to reflect a change in the URL structure. The domain has been updated from trendminer.cloud to trendminer.io, and a <TENANT> placeholder has been added to the URL pattern.

Key changes:

  • Updated URL domain from .cloud to .io
  • Added <TENANT> subdomain placeholder to URL patterns
  • Applied changes to Identifier, Reply URL, and Sign-on URL examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Author

@kgooris kgooris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#sign-off

@prmerger-automator
Copy link
Contributor

@kgooris, you can only sign off in the main PR conversation, not in review comments.

@kgooris
Copy link
Author

kgooris commented Nov 18, 2025

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @nguhiu

@v-dirichards
Copy link
Contributor

Hi @kgooris - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.


@nguhiu Could you take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants