Skip to content

Make builds green again #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Make builds green again #8

merged 1 commit into from
May 7, 2025

Conversation

fzhinkin
Copy link
Contributor

@fzhinkin fzhinkin commented May 7, 2025

No description provided.

@fzhinkin fzhinkin requested a review from sproshev May 7, 2025 13:31
@fzhinkin fzhinkin changed the title Replace unresolved symbol Make builds green again May 7, 2025
@fzhinkin fzhinkin requested a review from Ololoshechkin May 7, 2025 13:39
@sproshev
Copy link
Member

sproshev commented May 7, 2025

Sorry, I did not notice it before #13. It seems everything is fixed now

@fzhinkin fzhinkin force-pushed the fzhinkin/fix-compilation branch from 3cc161a to 421b6a3 Compare May 7, 2025 19:54
@fzhinkin
Copy link
Contributor Author

fzhinkin commented May 7, 2025

Besides broken compilation, there's also a test that is still failing, so it still makes sense to merge this PR

@fzhinkin fzhinkin merged commit 664ea99 into main May 7, 2025
3 checks passed
@fzhinkin fzhinkin deleted the fzhinkin/fix-compilation branch May 7, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants