Reworked FileSystemProvider #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM395 new problems were found
@@ Code coverage @@
+ 68% total lines covered
8868 lines analyzed, 6043 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
skarpovdev
requested changes
Aug 8, 2025
| @@ -44,8 +44,18 @@ public object FileSystemProvider { | |||
| * @return The resolved path object. | |||
| * @throws IllegalArgumentException if [path] is an absolute path. | |||
| */ | |||
| @Deprecated("Use joinPath instead", ReplaceWith("joinPath(base, path)")) | |||
| public fun fromRelativeString(base: Path, path: String): Path | |||
There was a problem hiding this comment.
I took a quick look at its usage and don't see it anywhere (IJ, JVM), but maybe missed something. Why don't we just replace it right away?
| @@ -134,8 +144,19 @@ public object FileSystemProvider { | |||
| * @throws IllegalArgumentException if the path doesn't exist or isn't a regular file. | |||
| * @throws IOException if an I/O error occurs during reading. | |||
| */ | |||
| @Deprecated("Use readBytes instead", ReplaceWith("readBytes(path)")) | |||
There was a problem hiding this comment.
Same for this one. Here only the name has changed.
rag/rag-base/src/commonMain/kotlin/ai/koog/rag/base/files/FileSystemProvider.kt
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
sproshev
reviewed
Aug 11, 2025
There was a problem hiding this comment.
@skarpovdev please let me know if you have more comments about the current state. If no, I'll remove deprecated methods
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
rag/rag-base/src/jvmMain/kotlin/ai/koog/rag/base/files/JVMFileSystemProvider.kt
Outdated
Show resolved
Hide resolved
harrytmthy
reviewed
Aug 11, 2025
| * @see [FileSystemProvider.ReadWrite.create] | ||
| */ | ||
| public suspend fun <Path> FileSystemProvider.ReadWrite<Path>.createFile(path: Path) { | ||
| create(path, FileMetadata.FileType.File) |
There was a problem hiding this comment.
NIT: createFile() and createDirectory() can still throw IOException if the path already exists (originates from the 2-arg create). Might be worth adding that to their KDocs for clarity.
There was a problem hiding this comment.
I did not put any details in this file intentionally and put see-references instead so there is no need to copy everything, let's see how it goes
|
@sproshev No more comments from me at this point, thanks for the quick fixes! |
and fixed typo in mockFileSystemProvicer
sproshev
force-pushed
the
es/fs-reworked
branch
from
e51fc82 to
c27e41c
Compare
skarpovdev
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature