Skip to content

Add message ids #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Add message ids #556

wants to merge 4 commits into from

Conversation

tiginamaria
Copy link
Collaborator

Add messages id to every type of the message
Fixes: https://youtrack.jetbrains.com/issue/KG-142/Add-Message-ID-to-all-Messages

Type of the change

  • New feature
  • Bug fix
  • Documentation fix
  • Tests improvement
  • Refactoring

Checklist for all pull requests

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@ptitjes
Copy link
Contributor

ptitjes commented Aug 8, 2025

Hey @tiginamaria ! As you convert all the ids to String, why not make internal factory functions for ids in the different modules? You would avoid putting the Uuid opt-in everywhere.

Copy link

github-actions bot commented Aug 8, 2025

Qodana for JVM

389 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 383
Vulnerable imported dependency 🔶 Warning 4
Unused import directive 🔶 Warning 1
String concatenation that can be converted to string template ◽️ Notice 1
@@ Code coverage @@
+ 68% total lines covered
8863 lines analyzed, 6047 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants