Skip to content

JBAI-13783. Merge agents-local with agents-core modules #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 9, 2025
Merged

JBAI-13783. Merge agents-local with agents-core modules #18

merged 8 commits into from
May 9, 2025

Conversation

sdubov
Copy link
Contributor

@sdubov sdubov commented May 8, 2025 •
edited
Loading

The main changes in commits:

  • Merged agents-local to agents-core module;
  • Drop agents-local-strategies module;
  • Rename agents-core-tools to agents-tools;
  • Rename agents-local-features to agents-features;
  • Extract a general interface for AIAgent.

@sdubov sdubov self-assigned this May 8, 2025
@sdubov sdubov added the refactoring Code improvements that enhance structure, readability, and quality without changing functionality label May 8, 2025
@sdubov sdubov force-pushed the sdubov/JBAI-13783 branch from 4393c68 to 66c1e94 Compare May 8, 2025 20:06
@sdubov sdubov changed the title JBAI-13783 JBAI-13783. Merge agents-local with agents-core modules May 8, 2025
@sdubov
Copy link
Contributor Author

sdubov commented May 8, 2025 •
edited
Loading

Some tests failed with "ERROR: environment variable OPEN_ROUTER_API_TEST_KEY not set". @sproshev, should not we set this in our environment?

@Rizzen
Copy link
Member

Rizzen commented May 8, 2025

@sproshev @sdubov I believe these tests should be muted in merge chain, at least for now

@sdubov
Copy link
Contributor Author

sdubov commented May 9, 2025

Ok. I will not relay on test at the moment. Let's fix it in a separate PR if you don't mind.

Rizzen
Rizzen approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@Rizzen Rizzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge, I'm waiting for it :)

@sdubov sdubov merged commit 8fa323e into main May 9, 2025
1 of 3 checks passed
@sproshev sproshev deleted the sdubov/JBAI-13783 branch May 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rizzen Rizzen Rizzen approved these changes

@sproshev sproshev Awaiting requested review from sproshev

@Ololoshechkin Ololoshechkin Awaiting requested review from Ololoshechkin

Assignees

@sdubov sdubov

Labels
refactoring Code improvements that enhance structure, readability, and quality without changing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdubov @Rizzen