Ability to pass in protected headers to sign_compact. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signatures may not validate if multiple (protected) headers are fed in. This is related to sign_compact computing the b64 representation of the protected headers (xargs) outside of the jwt, and then using jwt.pack() which would re-serialize the protected headeres, potentially changing the way the json is formatted.
|
Please note that test_private_key_from_jwk fails because jwk_private_key.json has not been committed. |
It is now.
”Capitalism is the extraordinary belief that the nastiest of men for the nastiest of motives will somehow work for the benefit of all" - John Maynard Keynes. |
rohe
pushed a commit
that referenced
this pull request
Jul 27, 2015
Ability to pass in protected headers to sign_compact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signatures may not validate if multiple (protected) headers are fed in. This
is related to sign_compact computing the b64 representation of the protected
headers (xargs) outside of the jwt, and then using jwt.pack() which would
re-serialize the protected headeres, potentially changing the way the json is
formatted.