Add decoding support for secret values in config package #504
Conversation
- Introduced a new field `Encoding` in the `Secret` struct to specify the encoding type of the secret value, currently supporting "base64". - Added a `DecodeContent` method to handle decoding of the secret content based on the specified encoding.
dgulli
requested review from
amitmodak,
NaMNDV,
dargudear-google and
abheda-crest
as code owners
- Update server to handle base64 encoded secrets during mount - Add test cases for base64 and non-encoded secret scenarios - Update example configuration template to demonstrate base64 encoding
|
/assign jainsuyogj |
|
Hi all, do i need to do anything here? there are workflows with pending checks and im not sure if i need to trigger anything on my side? @jainsuyogj or @dargudear-google any guidance? |
- Added environment variables for PROJECT_ID, CLUSTER_NAME, and LOCATION_ID using GitHub secrets. - Updated project_id in the setup-gcloud action to reference the new secret.
- Updated CLUSTER_NAME, PROJECT_ID, and LOCATION_ID to use environment variables with default values. - This change allows for more flexible configuration when running the script.
.DS_Store
Outdated
There was a problem hiding this comment.
This file is not required for the PR
There was a problem hiding this comment.
ok no worries, reverted to the original
There was a problem hiding this comment.
The file still is shown as a "created file" in this PR. Revert hasn't happened I believe
.github/workflows/e2e.yml
Outdated
There was a problem hiding this comment.
The {{ secrets.TEST_PROJECT_ID}} isn't defined in our project. Setting it empty(due to non existence) might cause problems to the default code in runner.sh. Maybe tests should catch this.
There was a problem hiding this comment.
ok no worries, reverted to the original
dgulli
changed the title
.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
@dgulli Can you do a "git rm .DS_Store" and "git rm .gitignore" on your branch and then push a commit?
If you wish, you can keep these file locally on your branch, but as you have pushed those changes, they will also get merged in the GCP repo, which we don't want.
|
@dgulli Do you have an concrete example of what use case this solves? |
Encodingin theSecretstruct to specify the encoding type of the secret value, currently supporting "base64".DecodeContentmethod to handle decoding of the secret content based on the specified encoding.