Skip to content

Allow a delegate service account to create a token #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

adhenderson
Copy link

iam.gke.io/gcp-service-account-delegates can be used to specify a delegate service account to create a token.

@tam7t
Copy link
Contributor

tam7t commented Feb 14, 2023

FYI I'm working on a 1.2.0 release now, will likely target this for 1.3

Copy link
Contributor

@tam7t tam7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating or adding a section to:

https://github.com/GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp/blob/main/docs/authentication.md

covering this usage pattern. Otherwise I think this change LGTM

@@ -111,3 +111,5 @@ For support
and if your issue isn't already represented please
[open a new one](https://github.com/GoogleCloudPlatform/secrets-store-csi-driver-provider-gcp/issues/new/choose).
Pull requests and issues will be triaged weekly.

updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a mistake

@dargudear-google
Copy link
Member

Looks like it is being worked in #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants